Lean: omit type abbreviations and leave a comment instead #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javra
force-pushed
the
lean/type_abbreviations
branch
from
3669305 to
5a683e0
Compare
javra
force-pushed
the
lean/type_abbreviations
branch
from
5a683e0 to
b787048
Compare
javra
force-pushed
the
lean/type_abbreviations
branch
from
b787048 to
67d4ad3
Compare
PeterSewell
reviewed
Feb 13, 2025
|
What is the reason they are expanded in the Coq frontend? |
|
They're not expanded everywhere, but I think the typechecker currently expands type abbreviations in every function signature. We should probably try to keep them more often. |
|
Okay, so I guess maybe I'll try to fix them instead of commenting them out. |
|
This has been superseded by #991. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type abbreviations are expanded by the rewrite passes anyway, so we don't need to print them as
abbrevs.